-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use fluentui to theme the person component. #2072
Conversation
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
* ci setup pipeline for preview release * altering setVersion script to ensure four part numeric version in package-solution.json * adding picker to the generated React code * fixing setversion logic and adding theme toggle
😃 waiting the the Storybook 😃 |
The updated storybook is available here |
1 similar comment
The updated storybook is available here |
The updated storybook is available here |
I feel we should never set a background color to the control. It should use the app's background color, right? Though, overall we are absolutely on the right track! |
I agree with you. For dev purposes, I start it out with a bg therefore before merge, I will ensure it's not set to be the same as the bg. |
The updated storybook is available here |
The updated storybook is available here |
The updated storybook is available here |
* fix person-card hover state styling * update: person card theming changes * add new person-card customization tokens * theme chat input, include new css props * theme the chat input border * chore: fix location icon color and refactor code * Update packages/mgt-components/src/utils/SvgHelper.ts * fix hover styles * fix perosn-card file-list section color * fix file-list item z-index issue * refactor fluent-tabs activeIndicator style padding * use hidden svgs to fix the hover fill persistence issue * Fix section nav border z-index issue * Fix section nav border z-index issue * update fluent-button aria labels and divider color * update profile section tokens * update fluent-button aria-labels * fix build * Fix build, remove fullView styles * fix eslint * use similar view for files compact and fullView, remove logging * fix additional eslint errors --------- Co-authored-by: Martin Musale <martinmusale@microsoft.com>
The updated storybook is available here |
The updated storybook is available here |
@musale There seems to have an issue with the presence badge on small avatars story. Is this related to the tokens or to the updates we made to the components? |
.github/workflows/pr-storybook.yml
Outdated
@@ -6,7 +6,7 @@ name: Deploy pr storybook | |||
on: | |||
pull_request: | |||
types: [opened, labeled, synchronize, reopened] | |||
branches: [main, release/**, next/**] | |||
branches: ['**'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm?
.github/workflows/pr.yml
Outdated
@@ -7,7 +7,7 @@ name: Build pr | |||
|
|||
on: | |||
pull_request: | |||
branches: [main, release/**, next/**, feat/add-jest-tests] | |||
branches: ['**'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to enable testing the sub-branches from this one. Reverting to main, release and next only.
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
It's a positioning issue for initials and contact icon avatars. It's now fixed. |
The updated storybook is available here |
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
The updated storybook is available here |
Closes #2073, Closes #2117
PR Type
Description of the changes
person-*
format for person component.PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information
I'm yet to fix usages of the person in other components. Still a WIP.