Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to SPFx v1.18 and node18 #2714

Merged
merged 2 commits into from
Sep 15, 2023
Merged

chore: upgrade to SPFx v1.18 and node18 #2714

merged 2 commits into from
Sep 15, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Sep 12, 2023

Closes #2715

PR Type

  • Other... Please describe: Dependencies update and move automation onto node 18

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner September 12, 2023 22:30
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@sebastienlevert sebastienlevert merged commit ab7f18e into main Sep 15, 2023
7 checks passed
@sebastienlevert sebastienlevert deleted the chore/node18 branch September 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[chore] Update to use SPFx v 1.18 and node 18
3 participants