Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align version header with spec #14

Closed
baywet opened this issue Nov 10, 2021 · 0 comments · Fixed by #15
Closed

align version header with spec #14

baywet opened this issue Nov 10, 2021 · 0 comments · Fixed by #15
Assignees
@baywet
Labels
bug Something isn't working fixed

Comments

@baywet
Copy link
Member

baywet commented Nov 10, 2021

following this conversation we need to update the request adapter for the v1.0 service library so the endpoint version doesn't show up in the telemetry header for v1.0.

beta is already conforming with the telemetry specification.

msgraph-sdk-go/graph_request_adapter.go

Line 12 in 150c7b3

GraphServiceVersion: "v1.0",

@baywet baywet self-assigned this Nov 10, 2021
@baywet baywet added the bug Something isn't working label Nov 10, 2021
baywet added a commit that referenced this issue Nov 10, 2021
@baywet
- fixes #14 a misalignement with telemetry specification
b1bdbee 
Signed-off-by: GitHub <noreply@github.com>
@baywet baywet mentioned this issue Nov 10, 2021
Merged
@baywet baywet added the fixed label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
bug Something isn't working fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/telemetry-header microsoftgraph/msgraph-sdk-go
1 participant
@baywet