Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer Flush Regression in XIO#write #225

Closed
fh-ms opened this issue Jul 23, 2021 · 2 comments
Closed

Buffer Flush Regression in XIO#write #225

fh-ms opened this issue Jul 23, 2021 · 2 comments
Assignees
@fh-ms
Labels
bug Something isn't working
Milestone
05.00.02

Comments

@fh-ms
Copy link
Contributor

fh-ms commented Jul 23, 2021 •
edited
Loading

Environment Details

  • MicroStream Version: 05.00.00-MS-GA, 05.00.01-MS-GA
  • JDK version: 8
  • Windows 10

Description

To ensure a physical buffer flush the XIO methods were updated to call different FileChannel#write methods and a subsequent flush. But the FileChannel#write(ByteBuffer[]) seems not to work reliably with bigger data.

Proposed fix

We have to remove the calls to the probably buggy FileChannel method.
@fh-ms fh-ms added the bug Something isn't working label Jul 23, 2021
@fh-ms fh-ms self-assigned this Jul 23, 2021
@fh-ms fh-ms added this to the 05.00.02 milestone Jul 23, 2021
fh-ms added a commit that referenced this issue Jul 23, 2021
@fh-ms
Fix buffer flush regression (#225)
c72f59c
@fh-ms
Copy link
Contributor Author

fh-ms commented Jul 23, 2021

Not reproducible under Linux. Probably a bug in the Windows NIO natives.

zdenek-jonas pushed a commit that referenced this issue Jul 23, 2021
@fh-ms @zdenek-jonas
Fix buffer flush regression (#225)
d6d55ae 
(cherry picked from commit c72f59c)
@fh-ms
Copy link
Contributor Author

fh-ms commented Jul 23, 2021

Fixed.

@fh-ms fh-ms closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fh-ms fh-ms

Labels
bug Something isn't working
Projects
None yet
Milestone
05.00.02
Development

No branches or pull requests
1 participant
@fh-ms