Inject js #65
Merged
Inject js #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MASNathan
commented
Aug 15, 2016
MASNathan
commented
- Added possibility to inject JS scripts or snippets into the page before screenshot
- Image format refactored
- Added Library specific Exception classes
- Minor fixes and docs update
- Changed timeout naming
URL validation moved into separate class
Added facebook utility scripts to inject
URL validation moved into separate class
Added facebook utility scripts to inject
Added timeout value validation
…re-js-injection # Conflicts: # src/Capture.php
| <?php if (isset($includedJsScripts)) : ?> | ||
| <?php foreach ($includedJsScripts as $script) : ?> | ||
| page.injectJs('<?php echo $script ?>'); | ||
| <?php endforeach ?> |
There was a problem hiding this comment.
Closing brace must be on a line by itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.