TextField : Label Typography 적용되도록 수정, Width Property 추가 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kh1012
approved these changes
Aug 21, 2023
| * width="10ex" | ||
| * width="10px" | ||
| */ | ||
| width?: string, |
| @@ -21,6 +22,9 @@ function Demo() { | |||
| <TextField placeholder={'placeholder'} /> | |||
| <br/><br/> | |||
| <TextField placeholder={'value'} value="valueTest"/> | |||
| <MoaStack> | |||
| <TextField placeholder={'value'} title="label" titlePosition="label" width="100%" value="width Test"/> | |||
There was a problem hiding this comment.
이건 궁금증!
placeholder={'value'}
placeholder='value'
이게 혹시 차이가 있나요?
There was a problem hiding this comment.
{ }는 값으로 주어진 변수를 참조하고, '' 또는 ""는 상수를 선언합니다.
변수에서 상수를 참조하는 것은 결국 상수인 셈이라 차이가 없을 것 같네요 ㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextField의 "Label" Property에 의해 표시되는 텍스트에 Typography가 적용되지 않고 있었음.
-> Typography 적용되도록 div -> Typography로 변경
mui Box를 사용하던 부분을 MoaStack으로 변경.
Width Property 추가 (이게 메인입니다)
작업하다가 필요하여 수정한 부분들을 묶어서 PR올립니다.