Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.page is still used in a couple of places, seems to be broken #912

Closed
manuelmeurer opened this issue May 28, 2013 · 2 comments
Closed

data.page is still used in a couple of places, seems to be broken #912

manuelmeurer opened this issue May 28, 2013 · 2 comments

Comments

@manuelmeurer
Copy link
Contributor

According to middleman/middleman-blog#107, data.page seems to be broken. It is still used in a couple of places:
https://github.com/middleman/middleman/blob/master/middleman-core/fixtures/frontmatter-app/source/front-matter-auto.erb
https://github.com/middleman/middleman/blob/master/middleman-core/features/front-matter-neighbor.feature
...
26 files in total.
Would a PR replacing all data.page occurrences with current_page.data be in order?
@bhollis
Copy link
Contributor

bhollis commented May 29, 2013

It isn't always broken, but yeah, I'd recommend strongly against using it. A PR to replace its usage with current_page.data would be great.

@manuelmeurer manuelmeurer mentioned this issue May 29, 2013
Merged
@manuelmeurer
Copy link
Contributor Author

PR here: #914

barraponto pushed a commit to barraponto/middleman that referenced this issue Nov 12, 2013
@manuelmeurer
Replace all occurrences of data.page with current_page.data
ed59260 
see middleman#912
@AndrewKvalheim AndrewKvalheim mentioned this issue Nov 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manuelmeurer @bhollis