New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax for Ruby 2.4.0 #2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Can we get a patch release for this one? Thanks :) |
Yes, can we please get a release? |
Can do |
Published as v4.2.1 |
tejasbubane
added a commit
to tejasbubane/bundler-site
that referenced
this pull request
May 31, 2017
Ruby version was [downgraded](rubygems@61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
bundlerbot
added a commit
to rubygems/bundler-site
that referenced
this pull request
May 31, 2017
Update to ruby 2.4 Ruby version was [downgraded](61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
tejasbubane
added a commit
to tejasbubane/bundler-site
that referenced
this pull request
Jun 9, 2017
Ruby version was [downgraded](rubygems@61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
tejasbubane
added a commit
to tejasbubane/bundler-site
that referenced
this pull request
Jun 9, 2017
Ruby version was [downgraded](rubygems@61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
bundlerbot
added a commit
to rubygems/bundler-site
that referenced
this pull request
Jun 9, 2017
Update to ruby 2.4 Ruby version was [downgraded](61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
illiailli
added a commit
to illiailli/bundler-site
that referenced
this pull request
Jan 13, 2023
Ruby version was [downgraded](rubygems/bundler-site@61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
illiailli
added a commit
to illiailli/bundler-site
that referenced
this pull request
Jan 13, 2023
Update to ruby 2.4 Ruby version was [downgraded](rubygems/bundler-site@61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038). Following gem updates were required: * middleman to version `4.2` and rubyracer to `0.12.3` for this to work. * `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason Ruby 2.4.0 didn't like
layout: proc do |...|
(butpartials: proc do |...|
right above works fine). I also added Ruby 2.4.0 to the Travis config.