Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax for Ruby 2.4.0 #2038

Merged
merged 2 commits into from Jan 11, 2017
Merged

Fix syntax for Ruby 2.4.0 #2038

merged 2 commits into from Jan 11, 2017

Conversation

manuelmeurer
Copy link
Contributor

For some reason Ruby 2.4.0 didn't like layout: proc do |...| (but partials: proc do |...| right above works fine). I also added Ruby 2.4.0 to the Travis config.

@tdreyno tdreyno merged commit eddb124 into middleman:master Jan 11, 2017
@manuelmeurer manuelmeurer deleted the fix_for_ruby_2_4_0 branch January 12, 2017 07:39
@vvo
Copy link

vvo commented Jan 20, 2017

Hi! Can we get a patch release for this one? Thanks :)

@kjg
Copy link
Contributor

kjg commented Jan 26, 2017

Yes, can we please get a release?

@tdreyno
Copy link
Member

tdreyno commented Jan 26, 2017

Can do

@tdreyno
Copy link
Member

tdreyno commented Jan 26, 2017

Published as v4.2.1

tejasbubane added a commit to tejasbubane/bundler-site that referenced this pull request May 31, 2017
Ruby version was [downgraded](rubygems@61ac8c6)
since middleman did not support ruby 2.4, but [now it
does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest
  versions to remove Fixnum warnings.
bundlerbot added a commit to rubygems/bundler-site that referenced this pull request May 31, 2017
Update to ruby 2.4

Ruby version was [downgraded](61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
tejasbubane added a commit to tejasbubane/bundler-site that referenced this pull request Jun 9, 2017
Ruby version was [downgraded](rubygems@61ac8c6)
since middleman did not support ruby 2.4, but [now it
does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest
  versions to remove Fixnum warnings.
tejasbubane added a commit to tejasbubane/bundler-site that referenced this pull request Jun 9, 2017
Ruby version was [downgraded](rubygems@61ac8c6)
since middleman did not support ruby 2.4, but [now it
does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest
  versions to remove Fixnum warnings.
bundlerbot added a commit to rubygems/bundler-site that referenced this pull request Jun 9, 2017
Update to ruby 2.4

Ruby version was [downgraded](61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
illiailli added a commit to illiailli/bundler-site that referenced this pull request Jan 13, 2023
Ruby version was [downgraded](rubygems/bundler-site@61ac8c6)
since middleman did not support ruby 2.4, but [now it
does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest
  versions to remove Fixnum warnings.
illiailli added a commit to illiailli/bundler-site that referenced this pull request Jan 13, 2023
Update to ruby 2.4

Ruby version was [downgraded](rubygems/bundler-site@61ac8c6) since middleman did not support ruby 2.4, but [now it does!](middleman/middleman#2038).

Following gem updates were required:

* middleman to version `4.2` and rubyracer to `0.12.3` for this to work.
* `builder`, `rake` and `sprockets` to their respective latest versions to remove Fixnum warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants