Issue/cv channels #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! :) Random Mode + Polyphony is a use case that I haven't really considered :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes several bugs I ran into when attempting to sequence a polyphonic eurorack voice module with my midiphy sequencer and euro modules.
The first commit simply fixes some multiple variable definition errors I ran into while compiling mios. Not sure why you wouldn't have run into this on your own builds, so maybe this is peculiar to my dev environment somehow?
The second commit fixes CV channel assignments when using the 9-12 and 13-15 channel ranges, and also actually lowers the accent pin if necessary.
The third commit fixes a bug I ran into when attempting to distribute CV/gates from multiple note layers using dupl fx. The two alternate modes and the random mode were using the number of midi channels rather than the first channel assignment as the base channel for the duplicated notes. The "forward to all" path seemed to be doing the right thing channel-wise, and so I replicated that behavior to the others. I tested this and it works as I would expect for a four voice module.
One observation I also had here is that the random mode samples with replacement and so doesn't necessarily work as one might expect for polyphony (i.e., you can have anywhere from 1 to n voices trigger for n note layers on each pass through a sequence), but I didn't attempt to address that here and maybe that is the intended behavior?