-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong code comments about relative and absolute time? #526
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is my understanding correct that "absolute time" can be interpreted as the time that has passed since the beginning of a song, whereas "relative time" can be interpreted as the time that has passed since the previous MIDI message?
If so, then
tick2second()
andsecond2tick()
are capable of converting absolute time in ticks or seconds to absolute time in seconds or ticks, as well as converting relative time in ticks or seconds to relative time in seconds or ticks. And they are often used for the latter (converting relative time).Therefore, the four occurrences of "absolute" should be removed from their docstrings.
And then this comment is wrong: relative (not absolute) time in ticks is being converted to relative time in seconds there.
By the way, why the singular "tick", "second" rather than "ticks", "seconds" in the name of the functions
tick2second()
andsecond2tick()
and their input argumenttick
?The text was updated successfully, but these errors were encountered: