-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve conversions between ticks and seconds #531
base: main
Are you sure you want to change the base?
Improve conversions between ticks and seconds #531
Conversation
Thank you for the nice discussions and commits! :) One comment: I'd favor renaming |
The unit is a property that is not descriptive enough IMHO. I find that I pondered using |
And thanks for the review! |
In what way do you consider Leaving out units would be a huge pain, especially in the context of MIDI, where time is so complicated already due to ticks vs. seconds vs. quarternotes and the various events that affect how to convert between those "units". "Resolution" might be given in ticks per quarternote, or ticks per second, or ticks per millisecond, or ticks per minute, or ticks per bar. Or maybe other things can also be considered "resolution", for example something related to the limited numerical precision of the inexact number of seconds that users might assume or recall from before the fix of #528, or the limited numerical precision of data in MIDI events such as tempo changes, or an assumption that |
|
Also the |
Deprecates tick2second in favor of ticks2seconds and second2tick in favor of seconds2ticks.
Returns fractional time is seconds per #528
Removes erroneous references to absolute in docstrings and comments.
Fixes #526