fix: use redis client before it's ready, most likely to occur during …

…unit test (#2102)

Co-authored-by: yaodong <wangyaodong@baoxiaohe.com>

packages/redis/src/manager.ts

@@ -74,12 +74,15 @@ export class RedisServiceFactory extends ServiceFactory<Redis> {
       client = new Redis(config);
     }
 
-    client.on('connect', () => {
-      this.logger.info('[midway:redis] client connect success');
-    });
-    client.on('error', err => {
-      this.logger.error('[midway:redis] client error: %s', err);
-      this.logger.error(err);
+    await new Promise<void>((resolve, reject) => {
+      client.on('connect', () => {
+        this.logger.info('[midway:redis] client connect success');
+        resolve();
+      });
+      client.on('error', err => {
+        this.logger.error('[midway:redis] client error: %s', err);
+        reject(err);
+      });
     });
 
     return client;

packages/redis/test/fixtures/base-app-bad-client/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "base-app",
+  "version": "1.0.0",
+  "dependencies": {
+  }
+}

packages/redis/test/fixtures/base-app-bad-client/src/config.default.ts

@@ -0,0 +1,10 @@
+export const redis = {
+  client: {
+    host: '128.0.0.2',
+    port: 6379,
+    password: '',
+    db: '0',
+    connectTimeout: 2e3,
+    retryStrategy: () => null
+  },
+};

packages/redis/test/fixtures/base-app-bad-client/src/configuration.ts

@@ -0,0 +1,14 @@
+import { Configuration } from '@midwayjs/decorator';
+import { join } from 'path';
+
+@Configuration({
+  imports: [
+    require('../../../../src')
+  ],
+  importConfigs: [
+    join(__dirname, './config.default'),
+  ]
+})
+export class AutoConfiguration {
+
+}

packages/redis/test/index.test.ts

@@ -58,4 +58,10 @@ describe('/test/index.test.ts', () => {
     await close(app);
   });
 
+  it('should fail when unable to connect redis', async () => {
+    await expect(createLightApp(join(__dirname, './fixtures/base-app-bad-client')))
+      .rejects
+      .toThrow('connect ETIMEDOUT');
+  });
+
 });