Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use redis client before it's ready, most likely to occur during unit test #2102

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

dongdongcpk
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2022

@dongdongcpk
Copy link
Contributor Author

帮忙看下 CI 的错误,需要协助调整单测

@czy88840616
Copy link
Member

有个test报错了吧

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2102 (e754aad) into main (8e187c4) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
- Coverage   81.89%   81.80%   -0.09%     
==========================================
  Files         426      426              
  Lines       14506    14517      +11     
  Branches     3413     3416       +3     
==========================================
- Hits        11880    11876       -4     
- Misses       2401     2414      +13     
- Partials      225      227       +2     
Impacted Files Coverage Δ
packages/redis/src/manager.ts 72.22% <100.00%> (+4.91%) ⬆️
packages/oss/src/manager.ts 38.88% <0.00%> (-50.00%) ⬇️
packages/oss/src/configuration.ts 60.00% <0.00%> (-40.00%) ⬇️
packages/swagger/src/swaggerExplorer.ts 79.81% <0.00%> (-0.92%) ⬇️
packages/web/src/logger.ts 69.67% <0.00%> (-0.82%) ⬇️
packages/swagger/src/swaggerMiddleware.ts 56.96% <0.00%> (-0.38%) ⬇️
packages/decorator/src/util/uuid.ts 100.00% <0.00%> (+55.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e187c4...e754aad. Read the comment docs.

@czy88840616 czy88840616 merged commit 3f4f0cd into midwayjs:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants