-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove egg-core from midway-core #159
Conversation
"camelcase": "^5.0.0", | ||
"debug": "^4.1.1", | ||
"egg-core": "^4.14.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
他这个是可以自己增加特定目录的加载器,貌似我们暂时用不到了。
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=========================================
+ Coverage 85.95% 88.1% +2.15%
=========================================
Files 41 36 -5
Lines 762 656 -106
Branches 45 42 -3
=========================================
- Hits 655 578 -77
+ Misses 97 68 -29
Partials 10 10
Continue to review full report at Codecov.
|
这次重构属于内部调整,我先发 next 版本,等内部一段时间后,再切 latest。 |
Merge pull request #159 from midwayjs/refactor_core refactor: remove egg-core from midway-core
|
这个 mr 是希望在 midway-core 这层和 egg-loader 解耦,把和 egg 相关的依赖都放到 midway-web 中,这样 midway-core 可以用在其他的场景,例如 faas。