Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Menu Option #82

Merged
merged 4 commits into from
Sep 1, 2016
Merged

Export Menu Option #82

merged 4 commits into from
Sep 1, 2016

Conversation

schneider42
Copy link
Collaborator

@schneider42 schneider42 commented Sep 1, 2016

This adds a menu option to export (filtered) samples from a file.

screenshot from 2016-09-01 00 50 26

If a tuner is activated (by adding a derived plot which uses it), the filtered samples will be used. The dialogue makes a recommendation for the decimation, based on the filter width.

Full file export uses multiple calls to SampleBuffer::getSamples() which leads do small discontinuities in the output file. I think this should be fixed in SampleBuffer::getSamples(). This is why I've added the experimental label to the option.

If cursors are activated, an option to only export the cursor selection is activated.

Things which should be improved (not necessarily in the PR):

  • The FIR filter length is constant and sometimes not large enough for good results
  • The complete file export is not "perfect"
  • The recommended decimation might have an odd/unusual value
  • Maybe there is a nicer and less invasive way to determine the decimation

Closes #49

@miek miek merged commit e936e51 into miek:master Sep 1, 2016
@miek miek mentioned this pull request Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export selection
2 participants