-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please tag releases #280
Comments
master should be stable enough, also I'm not really looking forward into writing changelogs 'n stuff. So I can tag, but I am not sure what that adds. |
Changelogs are really optional but tags are useful to define package dependencies like (>= 1.1). Always packaging top of master can be problematic... |
Tags are a detraction unless @miekg wants to do formal versioning such that |
@andrewtj, you can't pin commit in package dependencies. Version is different because it is incremental. Look at all important projects in Golang ecosystem -- Docker, Etcd (and many others) -- they use traditional versioning and for a good reason... It is OK it there is only one meaningful version. When new feature (or API breakage) introduced then a new tag can be made but one does not have to tag every commit. Another reason for tags/releases is to mark somewhat stable (better tested) versions comparing to random commit from master... |
That's more along the lines of what I tersely tried and failed to get at. (It's Sunday, give me a pass.) You're asking for more than just running Going beyond that to what you're asking for will take further commitment and that'll also fall on one person. There's benefits, but for my $0.02, I don't know that it'd be a win for the project at it stands. |
I am asking to follow software versioning practice that was established in the industry for somewhat 20 years. Only developers use |
Okay, I failed again. One last shot from another angle: @onlyjob, if a new version were tagged today, what would that mean? Things I wonder:
Again, I'm not disputing the value of formal versioning. I'm just saying I don't know if it'd be a clear win from what you've offered so far. You've said you need versions, okay, quantify what that entails. Then it'll be easier to judge the amount of work and who'll be prepared to do it. |
All those are up to whoever prepares a release. As for "supported" (if you can even define what it means) I suppose it will be no different from current situation (i.e. only latest release is "supported", whatever it means). I'm not going into details regarding how and when to increment release number. Usually it depends on accumulated changes. |
[ Quoting notifications@github.com in "Re: [dns] Please tag releases (#280..." ]
Yes, this is the "contract" for Go dns master branch. Versioning will help you, but will take up more time on my side. Time I Also in the 5+ years Go DNS has existed, none of the users of this lib have Wondering about that last thing; is this something you need in your code, or /Miek Miek Gieben |
I know package maintainers rarely trouble themselves to ask their upstreams for versioning... It is a packaging thing so versioning is suppose to be helpful to more people than just me... You do not need to worry about multiple versions as long as you support latest release. "Vendoring" is a bad thing but versioning helps to avoid bundled code copies. You might find it interesting to read Debian UpstreamGuide... We have a ticket to update Debian package. Since there are no releases yet, I suppose you would recommend to package HEAD of "master"? |
[ Quoting notifications@github.com in "Re: [dns] Please tag releases (#280..." ]
yep. I see the ticket is openend for SkyDNS. SkyDNS follows Go DNS very closely (I /Miek Miek Gieben |
On Sun, Nov 1, 2015 at 8:08 PM, Miek Gieben notifications@github.com
|
Good point, done via 497abb0 |
Formal releases are useful to define dependency relationships between software components; 3rd party developers would be able to bundle somewhat "stable" version of your software instead of just top of "master".
Also it is helpful to downstream maintainers for numerous reasons.
Please consider tagging. Thanks.
The text was updated successfully, but these errors were encountered: