Retain TC bit if original message was already marked truncated #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
- Coverage 55.17% 55.11% -0.06%
==========================================
Files 42 42
Lines 9581 9581
==========================================
- Hits 5286 5281 -5
- Misses 3271 3275 +4
- Partials 1024 1025 +1
Continue to review full report at Codecov.
|
tmthrgd
approved these changes
Oct 14, 2020
miekg
added a commit
that referenced
this pull request
Oct 14, 2020
Follow up after #1171, update the docs about TC and use the MinMsgSize constant for 512 in the code. Signed-off-by: Miek Gieben <miek@miek.nl>
miekg
added a commit
that referenced
this pull request
Oct 14, 2020
Follow up after #1171, update the docs about TC and use the MinMsgSize constant for 512 in the code. Signed-off-by: Miek Gieben <miek@miek.nl>
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
Follow up after miekg#1171, update the docs about TC and use the MinMsgSize constant for 512 in the code. Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain TC bit if original message was already marked truncated.
Fixes coredns/coredns#4183
This could alternately be fixed in coredns/coredns, although I can't think how reverting the TC bit would be desirable in any scenario, hence suggesting the fix upstream here.
Signed-off-by: Chris O'Haver cohaver@infoblox.com