Correctly handle $GENERATE modifiers #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2018 01:41
As per http://www.zytrax.com/books/dns/ch8/generate.html, the width and type (aka base) components of a modifier are optional. This means that ${2,0,d}, ${2,0} and ${2} are valid modifiers, however only the first format was previously permitted. Use default values for the width and/or type if they are unspecified in the modifier.
miekg
approved these changes
Jun 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
=========================================
+ Coverage 58.16% 58.77% +0.6%
=========================================
Files 37 37
Lines 10121 10127 +6
=========================================
+ Hits 5887 5952 +65
+ Misses 3171 3096 -75
- Partials 1063 1079 +16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle
$GENERATEmodifiers. The width and type (aka base)components of a modifier are optional. This means that
${2,0,d},${2,0}and${2}arevalid modifiers, however only the first format was previously permitted. Use default
values for the width and/or type if they are unspecified in the modifier.
While here improve test coverage by adding tests for parsing zones with
$GENERATEand themodToPrintfused by$GENERATE.Fixes issue #702