Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC 8032 functions added to x/crypto/ed25519 #715

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Jul 24, 2018

This was added in golang/crypto@5ba7f63082 and can replace the workaround from #458 / #591.

This was added in golang/crypto@5ba7f63082 and can replace the
workaround from miekg#458.
@tmthrgd tmthrgd requested a review from miekg July 24, 2018 10:17
@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #715 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   55.76%   55.77%   +0.01%     
==========================================
  Files          39       39              
  Lines       10753    10751       -2     
==========================================
  Hits         5996     5996              
+ Misses       3673     3672       -1     
+ Partials     1084     1083       -1
Impacted Files Coverage Δ
dnssec_privkey.go 96.77% <100%> (ø) ⬆️
dnssec_keyscan.go 70.89% <50%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8004f28...3b493dd. Read the comment docs.

@miekg miekg merged commit 1e845a5 into miekg:master Jul 25, 2018
@tmthrgd tmthrgd deleted the ed25519-seed branch July 26, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants