Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p11: return predefined errors #124

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

bonifaido
Copy link
Contributor

Signed-off-by: Nandor Kracser bonifaido@gmail.com

This helps to identify errors from the corresponding calls, which might be a bit more Go "idiomatic" maybe.

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
@langbeck
Copy link
Contributor

I would like to have this feature as well. Specially for errors like ErrNoObjectsFound to properly check if a matching object exists.
@miekg could you have a look at this?
@bonifaido I think you need to add him as reviewer so the activity stands out on its "Recent activity"

@bonifaido
Copy link
Contributor Author

You can't assign someone from a fork for reviewing (or at least I have no idea how to do that!). But your mention should be a correct ping I guess.

@langbeck
Copy link
Contributor

@bonifaido yes, you can. The owner of the PR can add someone as reviewer.
At least I was able to do so when I opened #133

@bonifaido
Copy link
Contributor Author

bonifaido commented Sep 23, 2020

The Reviewers button is not clickable by me.

@langbeck langbeck mentioned this pull request Oct 5, 2020
@bonifaido
Copy link
Contributor Author

@miekg - excuse meg for the ping, any chance to review/merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants