Make sure that the trash function doesn't delete the file if it cannot move it to trash

[markusd1984]

Button to "Clear All Segments" in the timeline and make it more obvious compared to the delete/trash icon?

I had a user working directly with a file on the network which has no recycle bin enabled and in the rush thought the bin icon is to delete/clear the timeline selections (or possible to get rid of the video in the timeline to insert a new one) and thus also ignored the warning message and as a result lost the original video.

Btw. "source file" may not necessarily be familiar to non techy people, perhaps change wording to "original file" and even include a remark that if they want to clear all segments instead that there is another way to do it (minus button or "clear all segments/timeline").

I would be actually in favour to use the trash icon to clear the time line and/or remove the video so it closes the project and present the "Drop Files" screen again (as not everyone thinks of dropping a new file over the existing project or using the file menu option to open one). Unless there is a common workflow more often used to keep adding files that require to delete the source files.... but it's rather easy enough to delete the file within the file explorer if/when needed.

[mifi]

I created an issue about the trash problem in the trash module. I think better to NOT delete the file if trash is not available.
I agree that the trash icon is a bit confusing and that the user might think it will trash the segments.
I think many people are used to File->Close (CTRL+W) for closing the current file tho

[markusd1984]

I think a button to clear the timeline selection and/or video entirely is helpful, as if somebody makes the effort to Close a project via File menu might as well instead click on File > Open and confirm the replace dialogue :) While clearing the video presents the Drag and drop screen that one is used to seeing at the program start (quicker/more intuitive).

Not sure why that trash was created in the first place, but just to use it as a substitute for replacing the existing video file when exporting a merged video seems rather overkill if not dangerous to me, risking loosing the original (source) file. Hence a better use for the clearing timeline/video in my opinion.

[mifi]

Maybe a better option would be:

• Trash icon clears video/timeline exactly like File->Close and CTRL+W, but it ALSO presents the user with a dialog asking them whether they want to delete the original file (with a RED button saying Yes, delete original, default to button No, Keep file).

Some people use the trash function (or rather the D hotkey) as part of their workflow for processing files and then quickly deleting them after

[mifi]

i added a dialog like this

[markusd1984]

sounds like a good combination, but note sure I fully understand the flow for all options.

Perhaps one click on trash to bring up dialogue with all three option would be better 😄

1. Clear all segment - CTRL + ???
2. Close Video (to add new) - CTRL + W
3. Delete original source file

[mifi]

When is the need to delete all segments? Can't you just hold down backspace until all are gone?

[markusd1984]

Didn't even know about backspace 😄 and most normal users wouldn't neither. Yeah I suppose it's not a regular use case scenario, if one needs to make changes to segments it's usually 1) amend cut points 2) delete individual segments 3) change order 4) add labels and lastly perhaps if somebody decides to start from scratch to clear all segments (instead of pressing minus symbol several times just like pressing backspace repeatedly).

[markusd1984]

@mifi might be enough to just have a clear all segments/clear timeline command under the file menu (for those really need it).

[mifi]

Gonna look into switching to shell.moveItemToTrash