Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note down version on icon set json files #7

Closed
fsbraun opened this issue Mar 10, 2023 · 3 comments
Closed

Note down version on icon set json files #7

fsbraun opened this issue Mar 10, 2023 · 3 comments

Comments

@fsbraun
Copy link
Contributor

fsbraun commented Mar 10, 2023

@migliori Still love your picker! Here's one thing that came to my mind:

To track down which version of the icon set belongs to I suggest to add a version property (string) which notes down the version of the icon set was used when generating the json file.

This needs not to be used by the picker but helps humans to keep track of the supported icon sets.

@migliori
Copy link
Owner

That's a good idea. I added the versions to the JSON icon files.

@fsbraun
Copy link
Contributor Author

fsbraun commented Mar 31, 2023

@migliori One more question: How do you create the JSON files? I saw the tool for FontAwesome. Say, I'd like to contribute an update on some library (bootstrap, e.g.). How can I create the JSON file?

@migliori
Copy link
Owner

migliori commented Mar 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants