Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE-2023-44487 - bump x/net dependency to 0.17.0 #155

Merged
merged 1 commit into from
Oct 19, 2023
Merged

CVE-2023-44487 - bump x/net dependency to 0.17.0 #155

merged 1 commit into from
Oct 19, 2023

Conversation

dymurray
Copy link
Contributor

No description provided.

jmontleon
jmontleon approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

kaovilai
kaovilai reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this go.mod has go 1.17
the std lib used could be outdated still?

@dymurray
Copy link
Contributor Author

As discussed this is minimum go version in go.mod doesn't impact the dep. And pinning it overrides what comes from the compiler.

@dymurray dymurray merged commit 64644f5 into migtools:main Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai left review comments

@jmontleon jmontleon jmontleon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dymurray @jmontleon @kaovilai