Parameterize the default hook-runner image (#877)

Let's us override this downstream to use a different value from upstream
and is configurable via the MigrationController CR

config/config.dev.json.example

@@ -7,5 +7,6 @@
   "namespace": "openshift-migration",
   "configNamespace": "openshift-config",
   "oauthClientSecret": "bWlncmF0aW9ucy5vcGVuc2hpZnQuaW8K",
-  "discoveryApi": "https://discovery-api.supercluster.example.com"
+  "discoveryApi": "https://discovery-api.supercluster.example.com",
+  "hookRunnerImage": "quay.io/konveyor/hook-runner:latest"
 }

config/webpack.dev.js

@@ -49,6 +49,7 @@ migMeta.oauth = {
 migMeta.namespace = localConfig.namespace;
 migMeta.configNamespace = localConfig.configNamespace;
 migMeta.discoveryApi = localConfig.discoveryApi;
+migMeta.hookRunnerImage = localConfig.hookRunnerImage;
 
 htmlWebpackPluginOpt.migMeta = Buffer.from(JSON.stringify(migMeta)).toString('base64');
 const PORT = process.env.PORT || localConfig.devServerPort;

src/app/plan/components/Wizard/HooksFormComponent.tsx

@@ -45,6 +45,7 @@ interface IHooksFormOtherProps {
   cancelAddEditWatch: () => void;
   resetAddEditState: () => void;
   currentPlan: any;
+  defaultHookRunnerImage: string;
 }
 const hookNameKey = 'hookName';
 const hookImageTypeKey = 'hookImageType';

src/app/plan/components/Wizard/HooksFormContainer.tsx

@@ -16,15 +16,14 @@ interface IHooksFormContainerValues {
 }
 interface IHooksFormContainerOtherProps {
   initialHookValues?: any;
+  defaultHookRunnerImage: string;
 }
 
-const defaultHookRunnerImage = 'quay.io/konveyor/hook-runner:latest';
-
 const AddEditHooksFormContainer = withFormik<
   IHooksFormContainerOtherProps,
   IHooksFormContainerValues
 >({
-  mapPropsToValues: ({ initialHookValues }) => {
+  mapPropsToValues: ({ initialHookValues, defaultHookRunnerImage }) => {
     const values: IHooksFormContainerValues = {
       hookName: '',
       hookImageType: 'ansible',

src/app/plan/components/Wizard/HooksStep.tsx

@@ -3,6 +3,7 @@ import { Table, TableBody, TableHeader } from '@patternfly/react-table';
 import { Spinner } from '@patternfly/react-core/dist/esm/experimental';
 import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing';
 import { PlusCircleIcon } from '@patternfly/react-icons';
+import { connect } from 'react-redux';
 
 import {
   Grid,
@@ -23,6 +24,8 @@ import { IMigHook } from '../../../../client/resources/conversions';
 
 const classNames = require('classnames');
 
+const fallbackHookRunnerImage = 'quay.io/konveyor/hook-runner:latest';
+
 const HooksStep = (props) => {
   const {
     updateHookRequest,
@@ -36,8 +39,10 @@ const HooksStep = (props) => {
     watchHookAddEditStatus,
     isAddHooksOpen,
     setIsAddHooksOpen,
+    migMeta,
   } = props;
 
+  const defaultHookRunnerImage = migMeta.hookRunnerImage || fallbackHookRunnerImage;
   const [initialHookValues, setInitialHookValues] = useState<Partial<IMigHook>>({});
 
   useEffect(() => {
@@ -142,6 +147,7 @@ const HooksStep = (props) => {
       {isAddHooksOpen && (
         <GridItem className={hooksFormContainerStyles}>
           <HooksFormContainer
+            defaultHookRunnerImage={defaultHookRunnerImage}
             onAddEditHookSubmit={onAddEditHookSubmit}
             initialHookValues={initialHookValues}
             setInitialHookValues={setInitialHookValues}
@@ -193,4 +199,7 @@ const HooksStep = (props) => {
     </Grid>
   );
 };
-export default HooksStep;
+
+export default connect((state) => ({
+  migMeta: state.migMeta,
+}))(HooksStep);