Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run order of didInsertParent for children of already-set-up parents #11

Closed
wants to merge 5 commits into from
Closed

Fix run order of didInsertParent for children of already-set-up parents #11

wants to merge 5 commits into from

Commits on Jun 4, 2019

  1. Remove second child-component in some did-insert-parent-hook-test cases 

    Sharing a single test spy between the two child-components can confuse order-dependent tests
referring to the order of events on a single component. Since the second child-component isn't
necessary for these tests, I'm removing it rather than giving each child-component its own spy.
    @reidab
    reidab authored and Greg Larrenaga committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    81f7564 View commit details
    Browse the repository at this point in the history

  2. Separate didInsertParent invocation from registerChild for alread… 

    …y-set-up parents

Fixes miguelcobain#10
    @reidab
    reidab authored and Greg Larrenaga committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    3774957 View commit details
    Browse the repository at this point in the history

  3. Use didInsertElement over on('didInsertElement'… 

    miguelcobain#10
    @reidab
    reidab authored and Greg Larrenaga committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    b406eb8 View commit details
    Browse the repository at this point in the history

  4. Fix comment typo

    @reidab
    reidab authored and Greg Larrenaga committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    b1ffc7e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Adds failing test

    Greg Larrenaga committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    c0bb308 View commit details
    Browse the repository at this point in the history