-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to find a valid digest in the 'integrity' attribute for resource #224
Comments
I had a similar issue running in production, and just ended up adding the empty integrity tag to every script and link tag. It resolved it for me. Don't think there's much we can do on our end here. Here is what my index works, and this is working fine for me. Did you add it to all tags? Note I haven't tested with the latest ember-cli, but this is working for me <!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>Client</title>
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">
{{content-for 'head'}}
<link rel="stylesheet" href="assets/vendor.css" integrity="">
<link rel="stylesheet" href="assets/client.css" integrity="">
{{content-for 'head-footer'}}
</head>
<body layout="row">
{{content-for 'body'}}
<script src="assets/vendor.js" integrity=""></script>
<script src="assets/client.js" integrity=""></script>
{{content-for 'body-footer'}}
</body>
</html> |
This issue is probably caused by some encoding problem somewhere in the included files, take a look here to follow the progress of the bug jonathanKingston/ember-cli-sri#5 . The simplest way to "solve" this while we're waiting for it to get fixed is to just remove the |
@mansona you will have trouble in old Chrome's if you don't have However all these issues are gone and actually That way you all get better security and this issue can be closed if it's ok. 😄 |
I have also this issue. I am using ember-cli 2.3.0-beta.2, ember-paper 0.2.11, ember-cli-sri 2.0.0. Testing in Chrome 48.0.2564.109 Windows/Linux and Firefox 44.0.1 Linux and integrity check fails. After disabling ember-paper integrity check is working fine. Currently for me only working solution is disabling ember-cli-sri. |
@mival do you have any other addons installed that might output the shape of your code before publishing? |
@jonathanKingston I use new ember-cli generated app and only install ember-paper. Config files attached. |
@jonathanKingston - I have the identical issue, using |
@DanChadwick yeah less and/or sass could be running after sri calculation which certainly would give you a bad time. There has been an update to fix unicode issues but I can't see that solving anything for you. A smaller example would help right now as my time is a little limited. Thanks! |
I also hit this issue today. I don't have any dependencies on LESS, so this may be an issue with SASS alone? For my app, disabling SRI entirely was an acceptable solution, so that's the route I've taken for now. I'd be willing to help test out fixes if anyone else needs a test subject, though. |
I've also run into this issue recently. I likewise disabled SRI since the app is not being used in a production environment. |
I got the same today, with the latest of everything and sri#^2.1.0. That's an OS project see https://github.com/MiguelMadero/ember-cli-bundle-loader-consumer, so it could help as a good test case. Since this is just a demo, I simply blanked the integrity attribute |
I ran into this same issue today (css files fail for SRI check in any browser when using ember cli 2.4 and ember paper). Here is what I discovered... ember-paper runs autoprefixer in a As a short term fix, rather than blank the integrity attribute you can move ember-paper before ember-cli-sri in your package json. I'll submit a PR shortly to ensure that ember-paper installs after ember-cli-sri so that the package.json order doesn't matter. |
@chbonser: Awesome! Can you submit the PR against branch |
@DanChadwick did you mean |
@chbonser: Just planning ahead. 😜 Yes. |
See PR #337. The build failed but it doesn't look like something that I caused. Please let me know if you need anything else from me. |
Closed by #337 |
I get this error on heroku (not locally)
It seems to be similar to this: ember-cli/ember-cli#5040, but I can not fix it by adding an empty
integrity
attribute to thelink
tag. (I can see another integrity attribute is added automatically)I am posting here because I broke the issue down to one of the
@import
statements in myapp.scss
:The
@import 'ember-paper';
- When I remove this line its working.Seems to be an issue in chrome only. No problem when using Firefox.
The text was updated successfully, but these errors were encountered: