Should Run Before SRI Integrity Generation #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this runs after the CSS & JS generation and the ember-cli-sri has run, the running app will fail to find a valid digest in the `integrity` attribute for the resource.
|
Thanks for the pull request. I've read through the comments on the referenced, but couldn't see a clear answer as to why it was failing for some and not for others. I've personally never run into this issue on our projects. The change is small, but i want to ensure it doesn't effect other people by merging that currently don't have the issue. Was it just a specific version of ember or sri that you had this error? |
|
@aaronbhansen The versions are Ember |
|
@kalebdf is this still an issue for you? I haven't run into or had anyone else with this issue. Looking to close this out if its resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this plugin runs CSS & JS generation after ember-cli-sri has run, the running app will fail to find a valid digest in the
integrityattribute for the resource.It seems to be similar to this: ember-cli/ember-cli#5040 and this issue in ember-paper
It seems to be an issue in Chrome only. No problem when using Firefox.