ensure 'parentNode' is not NULL in translate3d #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panthony
force-pushed
the
fix/destroyed
branch
from
e13135e
to
72c2019
Compare
|
I don't see any problem with adding these checks. |
|
@miguelcobain This error was reported in my sentry for some user using Safari on an iPhone. The web is dark and full of messy plugins manipulating the DOM beneath your feet, we should always be prepared! |
|
|
|
@panthony You're timing on fixing this bug could not have been better! Thank you so much! |
|
Thanks so much for this fix! My test suite was failing randomly/intermittently and I was having a hard time tracking it down. This was it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040
Fixes #1034