Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidenav + layout fixes to ember-paper #138

Merged
merged 6 commits into from
Aug 24, 2015

Conversation

peec
Copy link
Contributor

@peec peec commented Jul 23, 2015

Demo of this PR: http://jensb.home.pkj.no/ember-layout/index.html

This PR is about:

  • using latest angular-material scss sources for the sidenav and backdrop. Backdrop is also used in other components (menu) so we need to make it modular and removable from DOM.
  • paper-menu-toggle is now flexible and accepts any component (changed all to: paper-button (which gives e.g. ripple effect ).
  • paper-sidenav supports argument locked-open which supports all given constants (in constants service like in agular-material): sm, gt-sm, md, gt-md, lg, gt-lg etc. This means you can have many components with flexible lock-open on the menu.
    • Polyfill for window.matchMedia is included as a bower dependency. ( Which is needed to check for locked-open attributes ).
  • Cleaned up, moved demo related styles to "demo.scss". Styles that are needed is in app.scss still such as 100% width's / height's .
  • paper-backdrop: Now reusable ( many components use md-backdrop with a custom action ).
  • Now uses https://github.com/peec/ember-css-transitions so we can use angular's stylesheets for all animations.

Some of this are from ember-material-design, such as making menu animating ( see app/styles/paper-sidenav.scss )

Edit: Updated to latest 0.2.7

@peec peec mentioned this pull request Jul 26, 2015
10 tasks
@peec
Copy link
Contributor Author

peec commented Jul 29, 2015

Animations should now work ( and are generic implementation against angular's structure of defining animations in the css (that is compatible with $animate angular service.

peec added a commit to peec/ember-paper that referenced this pull request Jul 30, 2015
@peec peec mentioned this pull request Jul 31, 2015
}),

lockedOpenDefinition: Ember.computed.alias('locked-oppen'),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locked-oppen , should be open, and this is not used it seems.

@peec
Copy link
Contributor Author

peec commented Aug 5, 2015

@miguelcobain Refactored some code style to correct and polished this one, it should be good and contains latest scss for backdorp and also animation now works. This contains the important animation-mixin that is used to animate components and conforms to the ng-enter ng-enter-active style approach to animations (so we can use the CSS directly from angular ) Could you take a look at this one when you have fime ?

@peec
Copy link
Contributor Author

peec commented Aug 18, 2015

@miguelcobain This PR now uses ember-css-transitions. Demo updated also to see that backdrop works: http://jensb.home.pkj.no/ember-layout/index.html

peec added a commit to peec/ember-paper that referenced this pull request Aug 18, 2015
@miguelcobain miguelcobain merged commit e2a38ae into miguelcobain:master Aug 24, 2015
@miguelcobain
Copy link
Owner

@peec great work, as usual! I believe the introduction of ember-css-transitions is a step forward.

We can focus on possible animation improvements separately on that project.

Sorry for the delay in reviewing this, but my time is a bit limited at the moment (I'm hoping this will change soon).
Thanks!

mnutt added a commit to mnutt/ember-paper that referenced this pull request Aug 26, 2015
Fixes a missing dependency added by miguelcobain#138.
bj-mcduck pushed a commit to bj-mcduck/ember-paper that referenced this pull request Apr 28, 2016
bj-mcduck pushed a commit to bj-mcduck/ember-paper that referenced this pull request Apr 28, 2016
bj-mcduck pushed a commit to bj-mcduck/ember-paper that referenced this pull request May 1, 2016
bj-mcduck pushed a commit to bj-mcduck/ember-paper that referenced this pull request May 1, 2016
pauln pushed a commit to pauln/ember-paper that referenced this pull request Oct 28, 2016
pauln pushed a commit to pauln/ember-paper that referenced this pull request Oct 28, 2016
pauln pushed a commit to pauln/ember-paper that referenced this pull request Oct 28, 2016
pauln pushed a commit to pauln/ember-paper that referenced this pull request Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants