Added hooks for extending the Reflection API for custom data types and Elements #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch, but could you also extend the sample to show its use? |
|
sure, it might take me a few days to get it though. I'll probably just tack on an example to the existing reflection sample. |
|
Had some time to work on this. I added a demo using a simple custom view to bind to a custom data type using the reflection extension. It shows all the basics of how this is intended to be used. |
|
I've made a few changes to the reflection extension API to make it more flexible but I also found a bug where the Detail Text is not always cleared when RootElement cells get reused. This bug seems to exists regardless of any of my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some hooks for extending the Reflection API. It's a simple design that I used for when I had custom UI views that I wanted to bind to custom data value types. This allowed me to continue to use the reflection API data binding yet still get custom UI in a simple way.
It might be interesting to use these hooks for the basis of all Element building and value fetching to make the system more flexible (but I did not do that here).