Fix bug with transliteration of WooCommerce attributes and crushing v…

…ariations.
mihdan · Feb 20, 2021 · 9b7084e · 9b7084e
1 parent ff56ce3
commit 9b7084e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/classes/class-main.php b/classes/class-main.php
@@ -196,6 +196,8 @@ protected function is_wc_attribute_taxonomy( $title ) {
 			return false;
 		}
 
+		$title = str_replace( 'pa_', '', $title );
+
 		$attribute_taxonomies = wc_get_attribute_taxonomies();
 
 		foreach ( $attribute_taxonomies as $attribute_taxonomy ) {

diff --git a/tests/phpunit/tests/class-test-main.php b/tests/phpunit/tests/class-test-main.php
@@ -416,10 +416,11 @@ public function dp_test_sanitize_title_for_wc_attribute_taxonomy() {
 		];
 
 		return [
-			'no wc'             => [ 'color', false, null, 1 ],
-			'no attr taxes'     => [ 'color', true, [], 1 ],
-			'not in attr taxes' => [ 'color', true, $attribute_taxonomies, 1 ],
-			'in attr taxes'     => [ 'цвет', true, $attribute_taxonomies, 0 ],
+			'no wc'                  => [ 'color', false, null, 1 ],
+			'no attr taxes'          => [ 'color', true, [], 1 ],
+			'not in attr taxes'      => [ 'color', true, $attribute_taxonomies, 1 ],
+			'in attr taxes'          => [ 'цвет', true, $attribute_taxonomies, 0 ],
+			'in attr taxes with pa_' => [ 'pa_цвет', true, $attribute_taxonomies, 0 ],
 		];
 	}
 
@@ -567,7 +568,7 @@ function ( $arg ) {
 	}
 
 	/**
-	 * Data provider for test_sanitize_title
+	 * Data provider for test_sanitize_filename
 	 *
 	 * @return array
 	 */