Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The icon is always enabled at startup, even if the plugin is disabled #45

Closed
mihnita opened this issue Feb 1, 2020 · 2 comments
Closed

The icon is always enabled at startup, even if the plugin is disabled #45

mihnita opened this issue Feb 1, 2020 · 2 comments
Assignees
@mihnita
Labels
bug
Milestone
1.4.4

Comments

@mihnita
Copy link
Owner

mihnita commented Feb 1, 2020

No description provided.

@mihnita mihnita added bug P2 Priority 2. Bad, but there is an easy (and one time) workaround. labels Feb 1, 2020
@mihnita mihnita self-assigned this Feb 1, 2020
@mihnita mihnita removed the P2 Priority 2. Bad, but there is an easy (and one time) workaround. label Feb 1, 2020
@mihnita mihnita mentioned this issue Feb 5, 2020
Closed
@mihnita mihnita mentioned this issue Jun 6, 2020
Closed
This was referenced Jan 27, 2021
Closed
Closed
mihnita added a commit that referenced this issue Feb 3, 2021
@mihnita
Moved from actions (deprecated) to commands, fixing issue #45 and issue
0b417af 
#57
@mihnita mihnita mentioned this issue Feb 5, 2021
Closed
@mihnita
Copy link
Owner Author

mihnita commented Feb 5, 2021

In order to fix issue #45 I had to migrate from org.eclipse.jface.action (deprecated) to org.eclipse.core.commands,
which is something I wanted to do for a long time.

This (and #57) forced me into giving up control on the toggle colors (enabled / disabled).
Eclipse controls that now, and I don't like the result.
The toggle states are more difficult to distinguish, especially with the Dark theme.
But this is the Eclipse style, and it is used for all other buttons.
I've spent countless hours tweaking the colors, trying to make the difference more visible.

@mihnita mihnita added this to the 1.4.4 milestone Feb 5, 2021
@mihnita
Copy link
Owner Author

mihnita commented Feb 8, 2021

Released.

@mihnita mihnita closed this as completed Feb 8, 2021
@mihnita mihnita mentioned this issue Jul 9, 2021
Closed
@mihnita mihnita mentioned this issue Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihnita mihnita

Labels
bug
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
1 participant
@mihnita