Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a toggle button instead of a push button for enable/disable #57

Closed
laeubi opened this issue Jan 22, 2021 · 2 comments
Closed

Use a toggle button instead of a push button for enable/disable #57

laeubi opened this issue Jan 22, 2021 · 2 comments
Assignees
Labels
enhancement P3 Priority 3. Slightly annoying, but does not really get in the way.

Comments

@laeubi
Copy link

laeubi commented Jan 22, 2021

Currently one needs to decide from the icon if the action is enabled/disabled.

It would be much better if the button uses a toggle button.

@mihnita
Copy link
Owner

mihnita commented Jan 27, 2021

I kind of have something in the works.
It uses the standard Eclipse enable / disable, which also fixes #45.
And uses commands, better than the current approach (you can see them, assign hot-keys, etc.)
Cleaner than my old way of doing things.

But what I don't like about it is that I don't have control over the button image anymore.
It only allows for one image, and Eclipse algorithmically creates a "disabled" version.
That looks OK-is on Mac and Linux, but on Windows-dark mode is looks almost the same as the enabled one.
Really hard to distinguish.

I probably have to try it again with Eclipse 2020-12. They keep improving the dark support.

See the move_to_commands_working branch, if curious.

@mihnita mihnita self-assigned this Jan 27, 2021
@mihnita mihnita added enhancement P3 Priority 3. Slightly annoying, but does not really get in the way. labels Jan 27, 2021
@mihnita
Copy link
Owner

mihnita commented Feb 8, 2021

Implemented and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement P3 Priority 3. Slightly annoying, but does not really get in the way.
Projects
None yet
Development

No branches or pull requests

2 participants