Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates readme.md #18

Merged
merged 3 commits into from
Aug 1, 2019
Merged

updates readme.md #18

merged 3 commits into from
Aug 1, 2019

Conversation

rladstaetter
Copy link
Contributor

fixes typo; adds a hint to help cmake find Qt

fixes typo; adds a hint to help cmake find Qt
@miho
Copy link
Owner

miho commented Jul 29, 2019

Thanks for spotting the typo.

Copy link
Owner

@miho miho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather prefer consistent hints for CMake on Windows and Unix. Setting the prefix_path might work in this case but I prefer setting the Qt5_Dir.

Can you try whether setting the Qt5_Dir works for you as well?

Thanks.

@rladstaetter
Copy link
Contributor Author

i don‘t know why but setting Qt5_Dir didn‘t work for me. 😞

@miho
Copy link
Owner

miho commented Jul 29, 2019

Can you let me know your OS and the exact path you entered? Would like to fix this.

@miho
Copy link
Owner

miho commented Jul 29, 2019

and pls do a ls in the directory you entered. Then I'll try to reproduce it.

@rladstaetter
Copy link
Contributor Author

ok, it was a false alarm, my bad, i just provided the wrong directory for 'Qt5_Dir'.

I removed the superfluous entry concerning prefix_path, spotted another typo, added a hint for Qt5_Dir in the readme.md.

also added an entry for ignoring .idea/ in .gitignore.

@rladstaetter
Copy link
Contributor Author

i could compile nativefx-qt like described in the readme, just by providing the correct Qt5_Dir.

@miho
Copy link
Owner

miho commented Aug 1, 2019

Very cool. Thanks! Still would like to know your OS ;-) Linux or Mac?

@miho miho merged commit a89fd9e into miho:master Aug 1, 2019
@rladstaetter
Copy link
Contributor Author

i've tested NativeFX with macOS Mojave 10.14.5 👍

@rladstaetter rladstaetter deleted the patch-1 branch August 1, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants