Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:Firebase Warning - added get Vehicles after Vehicle additions #168

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Fix:Firebase Warning - added get Vehicles after Vehicle additions #168

merged 1 commit into from
Oct 14, 2023

Conversation

SarathVSasikala
Copy link
Contributor

What it Does

How I Tested

  • Add a list of steps to show the functionality of your feature
    For example:
  • Run the application
  • Navigate to the settings screen
  • Add new vehicle
  • Removed vehicle

mikaelacaron
mikaelacaron approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@mikaelacaron mikaelacaron merged commit 3be8ac3 into mikaelacaron:dev Oct 14, 2023
2 checks passed
0xJsaad added a commit to 0xJsaad/Basic-Car-Maintenance that referenced this pull request Oct 15, 2023
@0xJsaad
Merge branch 'dev' of https://github.com/0xJsaad/Basic-Car-Maintenance …
16a845c 
…into 139-firebase-analytics-add-update-delete

* 'dev' of https://github.com/0xJsaad/Basic-Car-Maintenance:
  Add Hindi localisation (mikaelacaron#167)
  Connect Vehicles and Maintenance Events (mikaelacaron#163)
  List ordered by amount of contributions and profile name (mikaelacaron#127)
  Update comment
  Fix:Firebase Warning - added get Vechicles after vechile additions (mikaelacaron#168)
  Fix:Firebase Warning - Implemented Event Sync function for sync with Firebase after additions or deletions. (mikaelacaron#164)
  updated EditEventDetail View title (mikaelacaron#162)
  Remove event from local model on delete (mikaelacaron#161)
  17 Alternate App Icons (mikaelacaron#156)

# Conflicts:
#	Basic-Car-Maintenance/Shared/Dashboard/Views/AddMaintenanceView.swift
#	Basic-Car-Maintenance/Shared/Dashboard/Views/EditEventDetailView.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelacaron mikaelacaron mikaelacaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG - Firebase Warning
2 participants
@SarathVSasikala @mikaelacaron