Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added russian localization #206

Merged
merged 2 commits into from
Oct 23, 2023
Merged

added russian localization #206

merged 2 commits into from
Oct 23, 2023

Conversation

arirays
Copy link
Contributor

@arirays arirays commented Oct 23, 2023

What it Does

How I Tested

  • Set system language to Russian
  • Start app

mikaelacaron
mikaelacaron approved these changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Note that you shouldn't have changed the bundle ID, that was noted in the README on how to set up the project with the xcconfig file.

I'm going to manually fix it for you, and merge this

Basic-Car-Maintenance.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
mikaelacaron
mikaelacaron reviewed Oct 23, 2023
View reviewed changes
Basic-Car-Maintenance.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Basic-Car-Maintenance.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Basic-Car-Maintenance.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Basic-Car-Maintenance.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@mikaelacaron mikaelacaron merged commit 778fa03 into mikaelacaron:dev Oct 23, 2023
2 checks passed
@arirays
Copy link
Contributor Author

arirays commented Oct 23, 2023

Thank you @mikaelacaron ! 👍

@arirays arirays deleted the issue-7-russian branch October 23, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelacaron mikaelacaron mikaelacaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arirays @mikaelacaron