Adds emitting of end event on error.

mikaelbr · Nov 6, 2014 · bd95de8 · bd95de8
1 parent 57f7583
commit bd95de8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/extra_api.js b/lib/extra_api.js
@@ -42,7 +42,11 @@ module.exports.onError = function (options, callback) {
     reporter = notifier.notify.bind(notifier);
   }
   return function (error) {
-    report(reporter, error, options, templateOptions, callback);
+    var self = this;
+    report(reporter, error, options, templateOptions, function () {
+      callback.apply(self, arguments);
+      self.emit && self.emit('end');
+    });
   };
 };
 

diff --git a/test/main.js b/test/main.js
@@ -610,12 +610,27 @@ describe('gulp output stream', function() {
       done();
     });
 
+
     it('should have onError event withReporter', function(done) {
       var notifier = notify.withReporter(mockGenerator);
       should.exist(notifier.onError);
       done();
     });
 
+    it('should call end on stream', function (done) {
+      var onError = notify.onError({
+        notifier: mockGenerator(function (opts) { })
+      });
+
+      var stream = through.obj(function (file, enc, cb) {
+        this.emit('error', 'error');
+        cb();
+      });
+
+      stream.on('error', onError).on('end', done);
+
+      stream.write({});
+    });
 
     it('should be limited by notifying on error if th onError-option is passed', function (done) {
       var