Set settings in .mversionrc files

[timkelty]

Feature request!

I think it would be great if mversion looked at it's current directory and up for any .mversionrc files and allowed you to put settings there.

[mikaelbr]

What kind of settings are you thinking of mainly? Something like:

{
  "commitMessage": "Bumps to version %s",
  "tagName": "v%s-src",
  "noPrefix": true,
  "push": "origin master"
}

(if push is being implemented - ref issue #14)

And then you would just do

$ mversion minor

To bump?

[timkelty]

@mikaelbr exactly!

[mikaelbr]

Good idea. This shouldn't alter any of the existing behaviour, though. And if for instance --tag "v%s" is passed, it should take precedence over the rc-file.

[timkelty]

Yep, agreed.

[timkelty]

With a place to set options, I could also see wanting an option for something like commandsAfter, where I might put npm publish. Though that could be a dedicated option as well.

[mikaelbr]

This is a very good idea I think. I'm a bit hesitant of adding features willy-nilly, but I think this sounds very useful.

I'm almost done implementing the rc-file now, just adding the final tests - and I'll look into adding scripts afterwords.

What is the best naming, you think?
post_scripts/pre_scripts (or with camelCase)
or commandsAfter/commandsBefore.

Any other?

[timkelty]

I'm ok with either. Just plain old after/before would be ok too, I think.

[mikaelbr]

I think the best naming would be preupdate and postupdate to match the naming conventions of https://www.npmjs.org/doc/misc/npm-scripts.html

I initially though of having a set of commands, as in

{
   "postupdate": [ "git push", "npm install" ]
}

But I think this increases the complexity and raises questions of sync or async etc. It's better to have:

{
   "postupdate": "git push && npm install"
}

[timkelty]

Agreed on both accounts.

[timkelty]

Will this just look in the dir where you're executing the commands, or it look all the way up the file system (like most rc files)?

[mikaelbr]

My thought was, since mversion requires you to be in the dir where package.json, bower.json or where ever is, it's also natural to think that the .mversionrc file would be there, no?

[timkelty]

Reasonable to assume, I think this is usually just how rc files work.
e.g. .jshintrc: http://www.jshint.com/docs/

This way you could just put your defaults in your home dir if you wanted to.

[mikaelbr]

Good thinking. Allowing for more global default settings.

[mikaelbr]

Available in version 1.3.0.

[timkelty]

Now that's what I call service!

Now I can ditch these silly grunt-bump dependencies and manage things globally.

Thanks!

[mikaelbr]

I use this over gulp-bump myself (obviously maybe?).
No worries, by the way. Very happy to help.

Thanks for a great issue and fantastic responses!