Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hang on Disabled Windows 10 Notifications #335

Merged
merged 2 commits into from Jul 21, 2020

Conversation

@JasonGore
Copy link
Contributor

@JasonGore JasonGore commented Jun 17, 2020

Fix named pipe server hang when notifications are disabled in Windows 10.

This PR can't address root cause (due to snoretoast's behavior) but at least resolves the hanging issue. I think it's important to fix with some kind of change at least temporarily to prevent a permanent hang in certain use cases. (More info in #334.)

Fixes #334.

@JasonGore
Copy link
Contributor Author

@JasonGore JasonGore commented Jun 17, 2020

The prettier pre-commit hook lint rules are at odds with the npm run lint configuration.

@JasonGore
Copy link
Contributor Author

@JasonGore JasonGore commented Jun 17, 2020

I had to use git commit --no-verify to fix the lint issues.

@JasonGore
Copy link
Contributor Author

@JasonGore JasonGore commented Jun 25, 2020

@mikaelbr Do you think there's any chance this fix will get merged? I want to deploy node-notifier but I can't since it will hang for some of our users. Thanks!

@mikaelbr
Copy link
Owner

@mikaelbr mikaelbr commented Jul 21, 2020

Thanks for this! Merging now

@mikaelbr mikaelbr merged commit 29b99f2 into mikaelbr:master Jul 21, 2020
1 check passed
@JasonGore
Copy link
Contributor Author

@JasonGore JasonGore commented Jul 21, 2020

@mikaelbr Thanks for merging! Do you know when the next release will occur?

@mikaelbr
Copy link
Owner

@mikaelbr mikaelbr commented Jul 21, 2020

Right about now!

+ node-notifier@7.0.2

Get it while it's fresh! 🍣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants