attribute values should be expressions

[Nowaker]

<img>
    <lsp:attribute name="alt" value="$user.name" />
    <lsp:attribute name="src" value="$user.profile.avatar" />
</img>

I'm quite surprised to see <img alt="$user.name" src="$user.profile.avatar" /> in output.

I see no point in writing <img><lsp:attribute name="alt" value="something"/></img>. lsp:attribute make sens when expressions are allowed in value attribute.

I consider it critical.

[Nowaker]

Thanks to debugger I digged into the source code and found out it will do the stuff:

<img>
    <lsp:attribute name="alt" value="{$user.name}" />
    <lsp:attribute name="src" value="{$user.profile.avatar}" />
</img>

There should be an example in documentation.

However, I would never think it could be this way. It's inconsistent to the rest of LSP. in lsp:value-of[select] I just write $var - why do I have to write {$var} in [lsp:attribute[value]?

[Nowaker]

Documented the feature via unit test. 39d3a36

[mikaelstaldal]

You don't have to use <lsp:attribute> at all in this case, just use this instead:
<img alt="{$user.name}" src="{$user.profile.avatar}"/>

<lsp:attribute> is only necessary if the name of the attribute is dynamic, or when used in combination with <lsp:element>.

(This is inspired from XSLT.)

[Nowaker]

I see. Looks good. BTW - I also tried <img lsp:alt="{$user.name} />" but didn't think of the simplest version.