You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
client=Lol::Client.new'<my_api_key>',region: 'na',rate_limit_requests: 10,rate_limit_seconds: 3600all_champions=client.static.champions.get# => project_path/vendor/ruby/2.4.0/gems/glutton_ratelimit-0.2.0/lib/glutton_ratelimit.rb:26: warning: constant ::Fixnum is deprecated# => TypeError: no implicit conversion of String into Integer
This also affects the summoner endpoint as well (https://github.com/mikamai/ruby-lol/blob/master/lib/lol/summoner_request.rb#L23), that errors with An hash is required as parameter. This is due to perform_rate_limited_request returning one because of the rate_limiter. PR #71 should fix this as well. I'm guessing that this affects more endpoints as well.
I stepped through
static_request.rb
and the problem seems to be coming from https://github.com/mikamai/ruby-lol/blob/master/lib/lol/request.rb#L131-L133The
times
method from@rates_limiter
is makingperform_rate_limited_request
return1
whenLol::Client
is initialized with rate limit info.I tried the exact same request except without the rate limit info:
And that worked without any problems.
The text was updated successfully, but these errors were encountered: