allow files to be used as HMAC secrets #111
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue I reported in #109, so that HMAC secrets can be read from a file. Previously, if one attempted to read from a file by passing
@filename
(as the --help text suggests), the literal string@filename
was used as the secret instead.As an aside, anyone who has used this tool with HMAC JWTs must have quite brute-forceable secrets, since they likely contain only printable characters.