handle @filename for HMAC secrets #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-engel
approved these changes
Jul 21, 2021
|
Thanks for your patience and for the PR @lizfeed! This will be included in the next version |
This was referenced Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #109
Summary
I didn't notice #111 until after I wrote this! I've got tests at least.
I don't love reaching deeper inside the bowels of main.rs to test a lower level method, but this was the most expedient way I found. I couldn't do the normal encode/decode thing, because
@/some/filewould still symmetrically encode/decode!I also hand-verified an example using the jwt.io debugger.
Preflight checklist