Skip to content
This repository
Browse code

No longer doing bundle dependencies

  • Loading branch information...
commit 6f0f8c5ee2b2fdc7118804664c2215fe9cb5a2f2 1 parent 42e5c3f
Mikeal Rogers authored

Showing 1 changed file with 0 additions and 1 deletion. Show diff stats Hide diff stats

  1. +0 1  package.json
1  package.json
@@ -12,6 +12,5 @@
12 12 , "engines" : ["node >= 0.3.6"]
13 13 , "main" : "./main"
14 14 , "dependencies": { "form-data":"~0.0.3", "mime":"~1.2.7" }
15   -, "bundleDependencies": ["form-data", "mime"]
16 15 , "scripts": { "test": "node tests/run.js" }
17 16 }

3 comments on commit 6f0f8c5

Andrei Neculau

@mikeal i've been reading on the issues of bundleDependencies including #313 , and now I see you've ditched them. I have 2 reasons to go towards bundling (1. have a local registry, and not make any external requests 2. some deps owners have breaking changes to their pkg, and even delete versions), but reading up on bundling, I see many issues.

Any experience sharing is highly appreciated.

Mikeal Rogers
Owner

bundling deps is great for deployable applications. this solves the "things can change in the registry" problem and it also gives you git diffs of all the changes you take in your deps. but for library maintainers its a huge pain in the ass. as the library maintainer i'm trusting other package maintainers i depend on a little more than you should deploying this with your application and that's really the only stable way to maintain all the modules in this giant ecosystem. that does not mean that you should share my optimism about the packages included in request and should still check the deps you pull in to the git repo of your application and evaluate the changes made.

Andrei Neculau

Point taken. Thank you, Mikeal

Please sign in to comment.
Something went wrong with that request. Please try again.