36 bounty done multiple claims #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r successful BountyDone proposal
* add nft test file
* make folder for test-nft
* Added test-nft to build
* Use prerelease near-sdk that supports NFTs and paste in example contract
* begin upgrading code to v4
* Use AccountId instead of VerifiedAccountId, and use new str logs
* Upgrade gas to use gas struct
* Convert token id to str for comparison
* Using safe versions of blockchain api
* finished types.rs
* change dereference to clone
* everything is building
* start updating tests and update test-token
* Update all dependencies to near-sdk v4
* All packages upgraded to near-sdk 4.0.0-pre.2
* Tests are building, but failing
* All build errors including building tests resolved. Now to fix logic bugs from tests
* fixed some small issues
* Use Gas() syntax instead of Gas{}
* removed fromstr, changed token_id to accept a string
* removed unneeded line
* remove unnecessary mocked_blockchain
* update unsafe code
* All tests passing!
* delete test-nft
* remove to_va()
* PR changes
* remove unncessary testing macro
Format all files in the repo
Fix compilation error that occurs with the latest version of near-sdk
…-test-test_create_dao_and_use_token Fix sputnikdao2 test
…orkflows-pr add pull_request to GitHub workflows
…rnings Remove unused imports that generate compilation warnings
* Related to near-daos#29 * Allows user to call bounty_done on multiple claims on the same bounty. * Removes the bounty on it's last payout. * I believe this fixes near-daos#19 * Add tests on various bounty errors.
swfsql
commented
Nov 18, 2021
| @@ -82,7 +85,7 @@ impl Contract { | |||
| format!("Bounty {} payout", id), | |||
| None, | |||
| ); | |||
| if bounty.times == 0 { | |||
| if bounty.times <= 1 { | |||
There was a problem hiding this comment.
I believe this change allows the bounty "done" proposal to be cleared up, and thus that proposal's bond to be returned
…-bounty-done-multiple-claims * merged near-daos#28. * kept the fix on claim clearing. * claims checks added on tests. * but also kept the possibility of multiple claims by the same user.
swfsql
commented
Nov 19, 2021
| } | ||
|
|
||
| #[test] | ||
| fn test_bounty_general2() { |
There was a problem hiding this comment.
This is the testing on multiple claims on the same bounty by the same user
swfsql
commented
Nov 19, 2021
| } | ||
|
|
||
| #[test] | ||
| fn test_bounty_general() { |
There was a problem hiding this comment.
This tests various errors and also normal functioning on a bounty.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that multiple claims are to be allowed, by the same user on the same bounty, this shows a possibility on how to allow a user to set the a bounty's claim to "done".