Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libvtk6-qt-dev dependency to build on Debian Stretch #4

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

mikaelarguedas
Copy link
Contributor

the libpcl-dev package is missing a dependency causing the Qt5::Widgets target to be exported but not satisfied.

This should fix the currently failing Stretch builds (e.g. http://build.ros.org/job/Lbin_ds_dS64__simple_grasping__debian_stretch_amd64__binary/1/)

the `libpcl-dev` package is missing a dependency causing the `Qt5::Widgets` target to be exported but not satisfied.
@mikeferguson mikeferguson merged commit 3438974 into mikeferguson:master Aug 15, 2018
@mikaelarguedas mikaelarguedas deleted the patch-1 branch August 15, 2018 00:45
@mikeferguson
Copy link
Owner

@mikaelarguedas -- it seems this prevents me from releasing into Lunar at all - -guess we need to update rosdep keys:

Releasing for rosdistro: lunar

Pre-verifying Debian dependency keys...
Running 'rosdep update'...
Could not resolve rosdep key 'libvtk6-qt-dev'
Failed to resolve libvtk6-qt-dev on ubuntu:xenial with: Error running generator: Failed to resolve rosdep key 'libvtk6-qt-dev', aborting.
libvtk6-qt-dev is depended on by these packages: ['simple_grasping']
<== Failed
Some of the dependencies for packages in this repository could not be resolved by rosdep.
You can try to address the issues which appear above and try again if you wish.

@mikeferguson
Copy link
Owner

Actually it seems the correct key is libvtk-qt -- I'm gonna fix that now

@mikaelarguedas
Copy link
Contributor Author

>_< I Used the ubuntu package name and not the rosdep key, the rosdep key looks to be libvtk-qt sorry about that

@mikaelarguedas
Copy link
Contributor Author

also just noticed there was a typo in my patch: "Needed yo work" -> "Needed to work"

@mikeferguson
Copy link
Owner

Yup -- both are fixed in 5ce2dfe

@mikaelarguedas
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants