Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Add a default http handler to Skill #34

Open
wants to merge 1 commit into
base: package-refactor-dev
Choose a base branch
from

Conversation

harrisonhjones
Copy link
Contributor

@harrisonhjones harrisonhjones commented Jan 4, 2018

Notes

To make life easier for skill developers I have added a default HTTP handler to the customskill package in this code change. See the example in customskill/examples/http.go. Tests have 100% coverage.

@harrisonhjones harrisonhjones changed the title Add a default http handler to Skill [Refactor] Add a default http handler to Skill Jan 4, 2018
@harrisonhjones
Copy link
Contributor Author

Friendly ping to @mikeflynn to take a look at this. I did this in response to your "let's make things easier for skill developers" comment on my last PR.

Copy link
Contributor

@rking788 rking788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what happens when I click Approve but lets see how it goes.

@mikeflynn
Copy link
Owner

This helps, but we should probably make the example do something, even if it just returns a voice response of "Hello world from go-alexa" would be something so a developer can see how to fully use the library.

@rking788
Copy link
Contributor

I think that makes sense too. I wonder if there should be a way to add links to existing skills that use this package? or repositories on Github that use it? That way it would be a way to show more examples of how to use the package as well as the other directives (and also good advertisement for anyone with a deployed skill).

@harrisonhjones
Copy link
Contributor Author

Yea, I'm down for adding an example. I'm working on something unlated to an Alexa skill at the moment but once I get back into Alexa development, maybe tonight if things go well, I'll look at addressing these conflicts and add examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants