Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling Fix #5

Merged
merged 4 commits into from Oct 27, 2016
Merged

Spelling Fix #5

merged 4 commits into from Oct 27, 2016

Conversation

parrker
Copy link
Contributor

@parrker parrker commented Oct 26, 2016

Hi,

Saw your post on Reddit, I think this is a cool little side project, especially as it's in TypeScript. I would like to help you a bit with bugs and improvements, when I can.

This is just the most obvious little thing that I noticed, but I'll try to be of more help later.

@parrker parrker changed the title Fixes the spelling of the "Aeolian" mode. Spelling Fix + Issue #1 Oct 26, 2016
@mikehadlow
Copy link
Owner

First pull-request! Excellent! Many thanks for this! The spelling correction is very much appreciated, I'll happily merge that commit. I'm not so sure about the upper-lower case of the roman numerals - see my comment on the issue.

If you can submit these two commits as two separate PRs, I'll merge the spelling correction right away, and let's talk about the roman numeral capitalisation.

@parrker
Copy link
Contributor Author

parrker commented Oct 26, 2016

Hi Mike, thanks for fast reply.

I wasn't sure how to split one pull request into two, so I just made one more commit reverting the changes made for capitalising major chords numerals.

Is this okay?

@mikehadlow
Copy link
Owner

Yes, that's fine. You'll still need to merge master though, because I've made some commits since you forked. BTW, sorry about all this, I hope it's not putting you off because I really do appreciate the contribution.

Conflicts:
	gtr-cof.js.map
	gtr-cof.ts
@parrker
Copy link
Contributor Author

parrker commented Oct 26, 2016

Okay, looks better now.

It's my first pull request in a long time, I'm sorry it takes me so long to do everything.

@parrker parrker changed the title Spelling Fix + Issue #1 Spelling Fix Oct 26, 2016
@mikehadlow
Copy link
Owner

Great, all looks good. Many thanks for this!

@mikehadlow mikehadlow merged commit cbfa7af into mikehadlow:master Oct 27, 2016
@sugizo sugizo mentioned this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants