Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Safari Light, Safari Dark themes #122

Merged
merged 2 commits into from
Jan 28, 2024
Merged

added Safari Light, Safari Dark themes #122

merged 2 commits into from
Jan 28, 2024

Conversation

vladstudio
Copy link
Contributor

as discussed here:
#107

"filePanelsBriefFocusedActiveItemBackgroundColor": "#0064E1",
"filePanelsBriefFocusedInactiveItemBackgroundColor": "#0064E155",
"filePanelsBriefSelectedItemBackgroundColor": "#FFF2BE",
"terminalFont": "IBM Plex Mono, 12",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't seem like something macOS ships by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, true, missed that. I'll revert to Menlo.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there are other monospaced fonts in macOS to try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: 58bf3bf

@mikekazakov mikekazakov merged commit 474591e into mikekazakov:main Jan 28, 2024
4 of 5 checks passed
@mikekazakov
Copy link
Owner

LGTM, thanks for adding the themes! 🥳
I realised that NC doesn't handle new built-in themes well if there were any overrides in the local config - the new themes might not show up, I will fix that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants