Skip to content

Commit

Permalink
Fixing up TODO and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
mikel committed Feb 24, 2010
1 parent af3b95d commit a33892c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
14 changes: 2 additions & 12 deletions TODO.rdoc
Original file line number Original file line Diff line number Diff line change
@@ -1,17 +1,7 @@
== Not really in any order: == Not really in any order:


* Make body, part, field, header, message all responding correctly to :encoded * Add multibyte handling to fields, if they get a multibyte string, try encoding it into
and :decoded messages. And remove ":to_s" as a method on these UTF-8 B first, if this fails, throw an error.
classes. Encoded needs to return the field, encoded, ready to send in the
mail system, that is, US-ASCII. Decoded needs to return the field decoded ready to
view. :to_s is (unfortunately) ambiguous in this case. Maybe return a warning
with :to_s and say "please use encoded or decoded instead" or :to_s returns
"Showing you the encoded view by default, call :decoded to see the decoded view"

* Refactor out the multibyte and string handling. Make ActiveSupport a dependancy

* Clean up the relationship between message, parts and bodies. Need to make sure
once parsed, that a body knows what encoding it is, for example.


* Cleanup the treetop parsers......... do I _really_ need that many entrance files? * Cleanup the treetop parsers......... do I _really_ need that many entrance files?


Expand Down
2 changes: 1 addition & 1 deletion lib/mail/network/delivery_methods/smtp.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module Mail
# Mail.defaults do # Mail.defaults do
# delivery_method :smtp, { :address => "smtp.gmail.com", # delivery_method :smtp, { :address => "smtp.gmail.com",
# :port => 587, # :port => 587,
# :domain => 'baci.lindsaar.net', # :domain => 'your.host.name',
# :user_name => '<username>', # :user_name => '<username>',
# :password => '<password>', # :password => '<password>',
# :authentication => 'plain', # :authentication => 'plain',
Expand Down

0 comments on commit a33892c

Please sign in to comment.